docs/README #643
Merged
Ladicek merged 3 commits intojakartaee:masterfrom Jan 3, 2023
ekimike:issue_642
Merged
Conversation
Closed
manovotn
reviewed
Jan 2, 2023
Contributor
I think I did try with 3.x some time ago and failed to make it work in current setup but I don't recall the details. |
Closed
Contributor
Author
|
Could you check this again, please? |
Ladicek
reviewed
Jan 3, 2023
Ladicek
approved these changes
Jan 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before pointing out that the Ruby 2.x version could be the only one for running Jekyll, I think it is better to put it as a recommendation instead of a fact because doing fast research, it seems Jekyll could work with Rubby 3.x, but I didn't test it.
The second change relates to the URL, just added the final part.